feat: add `import-deno` as crate feature to import using `.ts` extension #376

eythaann · 2024-12-17T22:09:27Z

Goal

Allow to generate files compatible with Deno projects.

Changes

I added a new feature import-deno works identically as import-esm but instead of import using .js Deno uses .ts

Checklist

I have followed the steps listed in the Contributing guide.
If necessary, I have added documentation related to the changes made.
I have added or updated the tests related to the changes made.

gustavo-shigueo · 2024-12-27T11:57:53Z

ts-rs/src/export.rs

The is_same_file check in lines 312-318 fails when using import-deno due to the trim_end_matches(".ts") in line 315, this line now needs to check if the feature flag is active

gustavo-shigueo

The --all-features test is failing due to the trim_end_matches problem mentioned above

feat: add import-deno as crate feature to import with .ts extension

30ba9d1

gustavo-shigueo reviewed Dec 27, 2024

View reviewed changes

gustavo-shigueo requested changes Dec 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `import-deno` as crate feature to import using `.ts` extension #376

feat: add `import-deno` as crate feature to import using `.ts` extension #376

eythaann commented Dec 17, 2024

gustavo-shigueo Dec 27, 2024

gustavo-shigueo left a comment

feat: add import-deno as crate feature to import using .ts extension #376

Are you sure you want to change the base?

feat: add import-deno as crate feature to import using .ts extension #376

Conversation

eythaann commented Dec 17, 2024

Goal

Changes

Checklist

gustavo-shigueo Dec 27, 2024

Choose a reason for hiding this comment

gustavo-shigueo left a comment

Choose a reason for hiding this comment

feat: add `import-deno` as crate feature to import using `.ts` extension #376

feat: add `import-deno` as crate feature to import using `.ts` extension #376